Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Majorityelement#229 #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Joshna907
Copy link

Being a learner in dsa, I have tried to solve the problem in the same enthusiasm.
Thank you, for assigning me .

@godkingjay godkingjay self-requested a review October 7, 2023 01:42
@godkingjay godkingjay added hacktoberfest-accepted Hacktoberfest participation. hacktoberfest Hacktoberfest issue. solution labels Oct 7, 2023
Copy link
Owner

@godkingjay godkingjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow our directory structure. You can see it in our README.


Changes to be made:

  • Follow Directory Structure
  • Rename file to Solution.java

@Joshna907
Copy link
Author

Please follow our directory structure. You can see it in our README.

Changes to be made:

  • Follow Directory Structure
  • Rename file to Solution.java

The work has been done. I have done it in the forked repo so I think if you merge it then it will be uploaded in the main.
If possible merge it as well, Lastly, it was fun as well as tough as I was a newbie and I didn't new much things.

Copy link
Owner

@godkingjay godkingjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions. However, you still haven't followed our directory structure which goes like this:

LeetCode/
├── [DIFFICULTY]/
│   ├── [PROBLEM]/
│   │   ├── README.md
│   │   ├── solution.java
│   │   ├── solution.cpp

Please remove also the duplicated file for your C++ Solution. And, remove also the Java Solution which you've added at the root folder.

Thank You!

Changes to be made:

  • Fix Directory Structure
  • Remove Duplicate C++ Solution
  • Remove JavaSolution at the root folder

@godkingjay godkingjay linked an issue Oct 7, 2023 that may be closed by this pull request
@Joshna907
Copy link
Author

Can you help me with this issue or guide me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest issue. hacktoberfest-accepted Hacktoberfest participation. solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem: 229. Majority Element II
2 participants