Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rider prerequisites to match Godot 3.2.3+ #4348

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

van800
Copy link
Contributor

@van800 van800 commented Nov 9, 2020

No description provided.

@Calinou Calinou requested a review from neikeq November 9, 2020 13:43
@paulloz
Copy link
Member

paulloz commented Nov 28, 2020

IMHO a lot of this page should be re-written or the whole setup/configuration part should be in a dedicated page.

Things are described in a weird order (this is partially fixed by this PR): it goes from setting up an environment to showing a script example to performances to setting up an environment again. The whole flow seems really confusing to new users.
Some notes are quite poorly written (at least I feel like they are) while not giving much information to begin with, e.g.

Built-in support for Visual Studio will be including in future versions, but in the meantime, the steps below can let you configure VS 2019 for use with Godot C# projects.

Altogether what could be a good page to direct new users to is more often than not... confusing. most of my contributions to the docs are about fixing mistakes and maintaining outdated stuff so I don't really know where to go from here, I just wanted to give my two cents as we see a lot of people struggling with installation/configuration asking for help on Discord. I know there is undergoing work about making the docs more straightforward and intelligible so maybe it'd be the right time to restructure this part too.

P.S. On a minor note, there's a broken anchor ref here.

(I apologize if this isn't the place to discuss this at all).

@aaronfranke
Copy link
Member

aaronfranke commented Dec 5, 2020

I'm concerned that the PR in its current state doesn't adequately give instructions for Mac and Linux. It says that you need .NET Core SDK, and that for Windows you need Visual Studio because it "contains utilities required to use C# in Godot". So where do Mac and Linux users get these utilities? If they're installed with .NET Core or Mono, why mention Visual Studio providing "utilities required" at all? Additionally, because of this same reason, it seems ambiguous as to whether or not the article wants JetBrains Rider users on Windows to also install Visual Studio for those utilities.

@van800
Copy link
Contributor Author

van800 commented Dec 5, 2020

@aaronfranke Well, afaik, installing VS would remove all previously installed dotnetcore sdk and install the latest, so VS installer kinda contains everything needed.
I don't use VSCode, so I can't add its section along with VS and Rider.

Anyway this state of documentation is a lot better than before.

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this now and then I will make a follow-up later with instructions for VS Code and adding some more details and clarification where needed.

@akien-mga akien-mga merged commit 01f1378 into godotengine:master Jan 4, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants