Remove MD5SHA1 OpenSSL 1.0.2 backport #239
Open
+2
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
ueno,
karianna,
derekparker,
dagood,
mertakman and
gdams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only implemented
crypto.MD5SHA1to support TLS 1.0/1.1 handshakes, which uses that hash in RSA PKCS1 v15 operations. Unfortunately, OpenSSL 1.0.2 doesn't provideEVP_md5_sha1, so we had to manually port it thinking that we could make that work by doing that.The reality is that our backport doesn't work, as demonstrated by the tests added in #235. Given it complexity, and that OpenSSL 1.0.2 is long past it's EOL date, we better remove it.