chore: remove deprecated rand.Seed() in testing.docker
#1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschi
force-pushed
the
golangci-lint-rand-seed
branch
from
7b8595a to
f48a0b5
Compare
Closed
|
@joschi Could you switch to |
Go 1.21 doesn't support `math/rand/v2`.
dhui
approved these changes
Sep 7, 2024
| @@ -22,7 +22,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go: ["1.21.x", "1.22.x"] | |||
| go: ["1.22.x"] | |||
There was a problem hiding this comment.
this is why I needed to bundle the change with the Go 1.23 update
charithe
referenced
this pull request
in cerbos/cerbos
Sep 16, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/aws/aws-sdk-go-v2/config](https://redirect.github.com/aws/aws-sdk-go-v2) | `v1.27.31` -> `v1.27.33` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/aws/aws-sdk-go-v2/service/marketplacemetering](https://redirect.github.com/aws/aws-sdk-go-v2) | `v1.23.4` -> `v1.23.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/bufbuild/buf](https://redirect.github.com/bufbuild/buf) | `v1.39.0` -> `v1.40.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/dadav/helm-schema](https://redirect.github.com/dadav/helm-schema) | `f205574` -> `7592f05` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | [github.com/golang-migrate/migrate/v4](https://redirect.github.com/golang-migrate/migrate) | `v4.17.1` -> `v4.18.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/golangci/golangci-lint](https://redirect.github.com/golangci/golangci-lint) | `v1.60.3` -> `v1.61.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/jackc/pgx/v5](https://redirect.github.com/jackc/pgx) | `v5.6.0` -> `v5.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/planetscale/vtprotobuf](https://redirect.github.com/planetscale/vtprotobuf) | `0393e58` -> `615f978` | | | | | require | digest | | [github.com/prometheus/client_golang](https://redirect.github.com/prometheus/client_golang) | `v1.20.2` -> `v1.20.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/vektra/mockery/v2](https://redirect.github.com/vektra/mockery) | `v2.45.0` -> `v2.45.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [go](https://go.dev/) ([source](https://redirect.github.com/golang/go)) | `1.23.0` -> `1.23.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | toolchain | patch | | golang.org/x/crypto | `v0.26.0` -> `v0.27.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | golang.org/x/exp | `9b4947d` -> `701f63a` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | golang.org/x/net | `v0.28.0` -> `v0.29.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | golang.org/x/tools | `v0.24.0` -> `v0.25.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [google.golang.org/genproto/googleapis/api](https://redirect.github.com/googleapis/go-genproto) | `7e3bb23` -> `8af14fe` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | [google.golang.org/grpc](https://redirect.github.com/grpc/grpc-go) | `v1.66.0` -> `v1.66.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [modernc.org/sqlite](https://gitlab.com/cznic/sqlite) | `v1.32.0` -> `v1.33.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | --- ### Release Notes <details> <summary>bufbuild/buf (github.com/bufbuild/buf)</summary> ### [`v1.40.1`](https://redirect.github.com/bufbuild/buf/blob/HEAD/CHANGELOG.md#v1401---2024-09-06) [Compare Source](https://redirect.github.com/bufbuild/buf/compare/v1.40.0...v1.40.1) - Fix issue with `buf lint` where comment ignores in the shape of `// buf:lint:ignore <RULE_ID> <extra comment>` were not recognized due to the extra comment. ### [`v1.40.0`](https://redirect.github.com/bufbuild/buf/blob/HEAD/CHANGELOG.md#v1400---2024-09-04) [Compare Source](https://redirect.github.com/bufbuild/buf/compare/v1.39.0...v1.40.0) - Add concept of a default lint or breaking rule, which is printed out as a property when running `buf config ls-{breaking,lint}-rules`. Default rules are those rules which are run if no lint or breaking rules are explicitly configured in your `buf.yaml`. - Rename `DEFAULT` lint rule category to `STANDARD`. With the concept of default rules being introduced, having a category named `DEFAULT` is confusing, as while it happens that all the rules in the `DEFAULT` lint category are also default rules, the name has become overloaded. As with all `buf` changes, this change is backwards-compatible: the `DEFAULT` lint category continues to work, and always will. We recommend changing to `STANDARD`, however. </details> <details> <summary>golang-migrate/migrate (github.com/golang-migrate/migrate/v4)</summary> ### [`v4.18.1`](https://redirect.github.com/golang-migrate/migrate/releases/tag/v4.18.1) [Compare Source](https://redirect.github.com/golang-migrate/migrate/compare/v4.18.0...v4.18.1) #### Changes - Update dktest from v0.4.2 to v0.4.3 **Full Changelog**: golang-migrate/migrate@v4.18.0...v4.18.1 ### [`v4.18.0`](https://redirect.github.com/golang-migrate/migrate/releases/tag/v4.18.0) [Compare Source](https://redirect.github.com/golang-migrate/migrate/compare/v4.17.1...v4.18.0) #### What's Changed - Bump golang.org/x/net from 0.21.0 to 0.23.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/golang-migrate/migrate/pull/1074](https://redirect.github.com/golang-migrate/migrate/pull/1074) - Make MySQL SetVersion compatible with sql_safe_update by [@​maxmati](https://redirect.github.com/maxmati) in [https://github.com/golang-migrate/migrate/pull/1070](https://redirect.github.com/golang-migrate/migrate/pull/1070) - [#​1104](https://redirect.github.com/golang-migrate/migrate/issues/1104) Fix golanglint-ci lint config & lint errors by [@​Shion1305](https://redirect.github.com/Shion1305) in [https://github.com/golang-migrate/migrate/pull/1105](https://redirect.github.com/golang-migrate/migrate/pull/1105) - 🧑💻 improve error message for invalid source, database, resolves: [#​1102](https://redirect.github.com/golang-migrate/migrate/issues/1102) by [@​Shion1305](https://redirect.github.com/Shion1305) in [https://github.com/golang-migrate/migrate/pull/1103](https://redirect.github.com/golang-migrate/migrate/pull/1103) - Upgrade go-sqlite3 to v1.14.22 by [@​gjabell](https://redirect.github.com/gjabell) in [https://github.com/golang-migrate/migrate/pull/1098](https://redirect.github.com/golang-migrate/migrate/pull/1098) - Fix redshift tests by [@​dhui](https://redirect.github.com/dhui) in [https://github.com/golang-migrate/migrate/pull/1151](https://redirect.github.com/golang-migrate/migrate/pull/1151) - chore: remove deprecated `rand.Seed()` in testing.docker by [@​joschi](https://redirect.github.com/joschi) in [https://github.com/golang-migrate/migrate/pull/1149](https://redirect.github.com/golang-migrate/migrate/pull/1149) - build: use Go 1.23 to build the project by [@​joschi](https://redirect.github.com/joschi) in [https://github.com/golang-migrate/migrate/pull/1133](https://redirect.github.com/golang-migrate/migrate/pull/1133) - fix(tests): fix Docker imports by [@​joschi](https://redirect.github.com/joschi) in [https://github.com/golang-migrate/migrate/pull/1153](https://redirect.github.com/golang-migrate/migrate/pull/1153) - test(postgres): run tests with PostgreSQL 16 by [@​joschi](https://redirect.github.com/joschi) in [https://github.com/golang-migrate/migrate/pull/1126](https://redirect.github.com/golang-migrate/migrate/pull/1126) - test(mysql): run tests with MySQL 8.0, 8.4, and 9.0 by [@​joschi](https://redirect.github.com/joschi) in [https://github.com/golang-migrate/migrate/pull/1127](https://redirect.github.com/golang-migrate/migrate/pull/1127) - Support .deb package for Noble Numbat (24.04) by [@​muzammilar](https://redirect.github.com/muzammilar) in [https://github.com/golang-migrate/migrate/pull/1119](https://redirect.github.com/golang-migrate/migrate/pull/1119) - Bump google.golang.org/grpc from 1.64.0 to 1.64.1 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/golang-migrate/migrate/pull/1152](https://redirect.github.com/golang-migrate/migrate/pull/1152) - CORRECTION DONE near m.Step(2) if you want to explicitly set the number of migrations to run by [@​adityassharma-ss](https://redirect.github.com/adityassharma-ss) in [https://github.com/golang-migrate/migrate/pull/1101](https://redirect.github.com/golang-migrate/migrate/pull/1101) A special thanks to [@​joschi](https://redirect.github.com/joschi) fixing tests and builds! #### New Contributors - [@​maxmati](https://redirect.github.com/maxmati) made their first contribution in [https://github.com/golang-migrate/migrate/pull/1070](https://redirect.github.com/golang-migrate/migrate/pull/1070) - [@​Shion1305](https://redirect.github.com/Shion1305) made their first contribution in [https://github.com/golang-migrate/migrate/pull/1105](https://redirect.github.com/golang-migrate/migrate/pull/1105) - [@​gjabell](https://redirect.github.com/gjabell) made their first contribution in [https://github.com/golang-migrate/migrate/pull/1098](https://redirect.github.com/golang-migrate/migrate/pull/1098) - [@​joschi](https://redirect.github.com/joschi) made their first contribution in [https://github.com/golang-migrate/migrate/pull/1149](https://redirect.github.com/golang-migrate/migrate/pull/1149) - [@​muzammilar](https://redirect.github.com/muzammilar) made their first contribution in [https://github.com/golang-migrate/migrate/pull/1119](https://redirect.github.com/golang-migrate/migrate/pull/1119) - [@​adityassharma-ss](https://redirect.github.com/adityassharma-ss) made their first contribution in [https://github.com/golang-migrate/migrate/pull/1101](https://redirect.github.com/golang-migrate/migrate/pull/1101) **Full Changelog**: golang-migrate/migrate@v4.17.1...v4.17.2 </details> <details> <summary>golangci/golangci-lint (github.com/golangci/golangci-lint)</summary> ### [`v1.61.0`](https://redirect.github.com/golangci/golangci-lint/compare/v1.60.3...v1.61.0) [Compare Source](https://redirect.github.com/golangci/golangci-lint/compare/v1.60.3...v1.61.0) </details> <details> <summary>jackc/pgx (github.com/jackc/pgx/v5)</summary> ### [`v5.7.0`](https://redirect.github.com/jackc/pgx/compare/v5.6.0...v5.7.0) [Compare Source](https://redirect.github.com/jackc/pgx/compare/v5.6.0...v5.7.0) </details> <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.20.3`](https://redirect.github.com/prometheus/client_golang/releases/tag/v1.20.3) [Compare Source](https://redirect.github.com/prometheus/client_golang/compare/v1.20.2...v1.20.3) - \[BUGFIX] histograms: Fix possible data race when appending exemplars. [#​1608](https://redirect.github.com/prometheus/client_golang/issues/1608) </details> <details> <summary>vektra/mockery (github.com/vektra/mockery/v2)</summary> ### [`v2.45.1`](https://redirect.github.com/vektra/mockery/releases/tag/v2.45.1) [Compare Source](https://redirect.github.com/vektra/mockery/compare/v2.45.0...v2.45.1) #### Changelog - [`1790d6a`](https://redirect.github.com/vektra/mockery/commit/1790d6a) Bump Go v1.22 to v1.23 in Dockerfile - [`38070f7`](https://redirect.github.com/vektra/mockery/commit/38070f7) Merge pull request [#​812](https://redirect.github.com/vektra/mockery/issues/812) from colega/patch-1 - [`2abbb49`](https://redirect.github.com/vektra/mockery/commit/2abbb49) Merge pull request [#​814](https://redirect.github.com/vektra/mockery/issues/814) from khaifazil/patch-1 - [`b2c2927`](https://redirect.github.com/vektra/mockery/commit/b2c2927) Update index.md: capitalize "Grafana" </details> <details> <summary>golang/go (go)</summary> ### [`v1.23.1`](https://redirect.github.com/golang/go/compare/go1.23.0...go1.23.1) </details> <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.66.1`](https://redirect.github.com/grpc/grpc-go/compare/v1.66.0...v1.66.1) [Compare Source](https://redirect.github.com/grpc/grpc-go/compare/v1.66.0...v1.66.1) </details> <details> <summary>cznic/sqlite (modernc.org/sqlite)</summary> ### [`v1.33.0`](https://gitlab.com/cznic/sqlite/compare/v1.32.0...v1.33.0) [Compare Source](https://gitlab.com/cznic/sqlite/compare/v1.32.0...v1.33.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/cerbos/cerbos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXJlYS9kZXBlbmRlbmNpZXMiLCJib3RzIiwia2luZC9jaG9yZSJdfQ==--> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Charith Ellawala <charith@cerbos.dev> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Charith Ellawala <charith@cerbos.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint complains about the use of
rand.Seed(...):See also: