clickhouse: Quote db name in ensureVersionTable #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-nardelli
force-pushed
the
master
branch
from
d055e2b to
9fe7383
Compare
dhui
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
@luca-nardelli Thanks for the PR! And sorry for the slow response...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Today I wanted to use migrate on a clickhouse cloud cluster where we were setting up databases with dashes in their name, e.g.
database-name. This brokemigratesince the SHOW TABLES query for clickhouse did not quote the database name, hence this PR.