Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force use of default diff #7

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Conversation

dan-smetana
Copy link

@dan-smetana dan-smetana commented Aug 28, 2023

This fix resolves issues that arise when the user has configured an alternative diff provider through diff.external. It also ensures that the default prefix setting is consistently used, allowing revgrep to operate correctly regardless of user settings.

golangci/golangci-lint#4060

https://git-scm.com/docs/git-diff

@ldez ldez changed the title Fix: Always Use Default Diff fix: always use default diff Sep 2, 2023
@ldez ldez self-requested a review September 2, 2023 10:55
@ldez ldez changed the title fix: always use default diff fix: force use of default diff Sep 2, 2023
@ldez ldez added the bug Something isn't working label Sep 2, 2023
This fix resolves issues that arise when the user has configured an
alternative diff provider through diff.external. It also ensures that
the default prefix setting is consistently used, allowing `revgrep` to
operate correctly regardless of user settings.
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 358f9e2 into golangci:master Sep 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants