Skip to content

Commit

Permalink
Add commit style and add a PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
golf1052 committed Oct 8, 2017
1 parent 1d19f73 commit cd30c8c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Pushing Changes

When pushing changes make sure that code changes and theme updates are in separate commits. For example [code changes for 1.3.0](https://github.com/golf1052/base16-generator/commit/4eab7a3b13ad951adf1984f1827a7f58480cd208) and separate [theme update commit](https://github.com/golf1052/base16-generator/commit/a331be7eb4b45bc980ebdf7058c59c09b393b12a).
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ If you want or need to run the steps manually
### Testing Theme Changes

#### Things To Look At

[VSCode Theme Color Reference](https://code.visualstudio.com/docs/getstarted/theme-color-reference)
[Base16 Website](http://chriskempson.com/projects/base16/)
[Base16 Theme Examples](https://chriskempson.github.io/base16/)
Expand All @@ -45,3 +46,7 @@ If you want or need to run the steps manually
4. Modify `builder/templates/vscode/templates/default.mustache` to reflect the changes made in `reference-theme/base16-ocean-dark.json`. Follow the template hex variables found [here](https://github.com/chriskempson/base16/blob/master/builder.md#template-variables).
5. Copy `builder/templates/vscode/templates/default.mustache` to `/path/to/base16-builder/templates/vscode/templates/` (see step 4 from [Setup Builder](#Setup-Builder).
6. Follow the steps in Generate Themes

## Pushing Changes

When pushing changes make sure that code changes and theme updates are in separate commits. For example [code changes for 1.3.0](https://github.com/golf1052/base16-generator/commit/4eab7a3b13ad951adf1984f1827a7f58480cd208) and separate [theme update commit](https://github.com/golf1052/base16-generator/commit/a331be7eb4b45bc980ebdf7058c59c09b393b12a).

0 comments on commit cd30c8c

Please sign in to comment.