Log rewards statistics in SAC agents. #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm submitting this as a separate PR other than #231 to ease the review process, but it'd be great if each of the PRs can be rebased/merged without creating a merge commit when being merged. Thanks! |
(similar to PPO agents)
qstanczyk
approved these changes
Jul 5, 2022
|
@qstanczyk, Thank you for the update on the PR after a long time! I understand DM may not have enough resources available, but as a general request, It'd be greatly appreciated if the turnaround time for community contributions could be reduced further. |
cop4587
pushed a commit
to cop4587/acme-molax
that referenced
this pull request
Jul 5, 2022
-- 5e38355 by Jongwook Choi <wookayin@gmail.com>: Log rewards statistics in SAC agents (similar to PPO agents) COPYBARA_INTEGRATE_REVIEW=google-deepmind#232 from wookayin:sac-log-reward 5e38355 PiperOrigin-RevId: 459035815 Change-Id: I47181e44776cac8f76ebbbf95fbcf46ccb40c6d7
alex-gran23
pushed a commit
to Next-Step-Fusion/acme
that referenced
this pull request
Feb 23, 2024
-- 5e38355 by Jongwook Choi <wookayin@gmail.com>: Log rewards statistics in SAC agents (similar to PPO agents) COPYBARA_INTEGRATE_REVIEW=google-deepmind#232 from wookayin:sac-log-reward 5e38355 PiperOrigin-RevId: 459035815 Change-Id: I47181e44776cac8f76ebbbf95fbcf46ccb40c6d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPO agents have
reward_meanandrewards_stdmetrics logged, but SAC agents do not have.Note that the SAC implementation is not so flexible that custom metrics cannot be configured or extended (because update_step is not a method), so it would be reasonable to add them directly into the update_step function.