Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated model and checkpoints to run in tf v2. #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brunomcebola
Copy link

Changes:

  1. Folder Structure:

    • Moved the existing codebase to a new folder named tf_v1.
    • Created a new folder named tf_v2 to accommodate the updated version.
  2. Migration:

    • Migrated the model and associated checkpoints from TensorFlow v1 to TensorFlow v2 within the tf_v2 folder.
  3. Environment Setup:

    • Added requirements.txt and .python-version files to both the tf_v1 and tf_v2 folders to ensure proper environment setup and compatibility with respective TensorFlow versions.

@brunomcebola
Copy link
Author

@diegolascasas

@joaoluiscarreira
Copy link

Thanks! Do we need to have the data folder copied into both tf1 and tf2 folders or would it be better to keep it shared ? Did you test both versions ?

@brunomcebola
Copy link
Author

brunomcebola commented Oct 10, 2024

Regarding the data folder, the actual data (.txt, .npy and .gif) could be shared accross both versions. The checkpoints, however, are version specific and should be left inside the respective folder for organization sake.

Nonetheless, since the access to this data is performed by setting the constants at the beginning of the scripts (making it possible for this folder to anywhere on the user machine), I choose to keep it separate just be more user friendly for anyone wanting to use the code.

Regarding the test of both versions, yes, I tested them and both worked in my machine with GPU support. An important note however are the subversions of tf, which need to be chosen according to the cuda versions, but this does not afect the final code of each version at all.

Hope this has been clear!

Copy link

@joaoluiscarreira joaoluiscarreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants