Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a mathematical description of AdaGrad optimizer #1011

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

Abhinavcode13
Copy link
Contributor

@Abhinavcode13 Abhinavcode13 commented Jul 15, 2024

Addresses : #757
cc: @vroulet
ref for the information used: here

@Abhinavcode13 Abhinavcode13 changed the title feat: add a mathematical description of AdamGrad optimizer feat: add a mathematical description of AdaGrad optimizer Jul 15, 2024
optax/_src/alias.py Outdated Show resolved Hide resolved
Abhinavcode13 and others added 2 commits July 15, 2024 22:08
Co-authored-by: Fabian Pedregosa <pedregosa@google.com>
@Abhinavcode13
Copy link
Contributor Author

@vroulet anything else to be addressed in this?

Copy link
Collaborator

@vroulet vroulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, thanks for doing that!

optax/_src/alias.py Show resolved Hide resolved
optax/_src/alias.py Outdated Show resolved Hide resolved
@vroulet
Copy link
Collaborator

vroulet commented Jul 16, 2024

If possible could you attach a screenshot of the doc once built?

optax/_src/alias.py Outdated Show resolved Hide resolved
@copybara-service copybara-service bot merged commit 289e1b5 into google-deepmind:main Jul 17, 2024
8 checks passed
@Abhinavcode13 Abhinavcode13 deleted the patch-2 branch July 17, 2024 11:56
@Abhinavcode13
Copy link
Contributor Author

Sorry, there are a few broken issues with this merged PR that have been fixed in the most recent PR #1016.
cc: @vroulet @fabianp

@vroulet
Copy link
Collaborator

vroulet commented Jul 17, 2024

No worries, if possible try to build the html and send a pic when you do changes in the docs.
Thanks again for doing this.

@Abhinavcode13
Copy link
Contributor Author

Yes, I added a snapshot in the recent pr of the compiled rst file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants