-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a mathematical description of AdaGrad optimizer #1011
Conversation
Co-authored-by: Fabian Pedregosa <pedregosa@google.com>
@vroulet anything else to be addressed in this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, thanks for doing that!
If possible could you attach a screenshot of the doc once built? |
No worries, if possible try to build the html and send a pic when you do changes in the docs. |
Yes, I added a snapshot in the recent pr of the compiled |
Addresses : #757
cc: @vroulet
ref for the information used: here