Modify clipping implementation to avoid jnp.moveaxis, which causes undesirable all-to-all's in distributed environments. #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_671865728
branch
14 times, most recently
from
b973090
to
fac9ca1
Compare
copybara-service
bot
force-pushed
the
test_671865728
branch
2 times, most recently
from
fab1981
to
8059866
Compare
copybara-service
bot
force-pushed
the
test_671865728
branch
from
8059866
to
2a88336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify clipping implementation to avoid jnp.moveaxis, which causes undesirable all-to-all's in distributed environments.
Also improve documentation on per_example_global_norm_clip and per_example_layer_norm_clip, and refactor them to consume PyTrees instead of lists.