Add optax.tree_utils.tree_random_split. #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgmartin
force-pushed
the
tree_random_split
branch
2 times, most recently
from
8a76fd4
to
b9bdf05
Compare
vroulet
reviewed
Sep 17, 2024
carlosgmartin
force-pushed
the
tree_random_split
branch
from
b9bdf05
to
83e5369
Compare
|
Thanks for doing that, it's a good idea, happy to know it can be useful. (sorry for the incremental review, didn't mean to do it like that). |
carlosgmartin
force-pushed
the
tree_random_split
branch
from
83e5369
to
a9603c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the formerly private function
_tree_rng_keys_splitinoptax/tree_utils/_random.pyto the public API.I've found this to be a useful helper function for manipulation of random trees, and intend to use it for future PRs.