Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test.sh, which uses set -u, so that it works when JAX_VERSION is unset. #1070

Merged

Conversation

carlosgmartin
Copy link
Contributor

@carlosgmartin carlosgmartin commented Sep 23, 2024

Currently, running

sh ./test.sh

as described in the readme yields the following error:

./test.sh: line 45: JAX_VERSION: unbound variable

This is because the script uses nounset (set -u), which treats an unset variable as an error (not an empty string).

This forces one to do

JAX_VERSION= sh ./test.sh

This PR fixes test.sh so that it works when JAX_VERSION is unset.

Copy link
Member

@fabianp fabianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@copybara-service copybara-service bot merged commit 84bd835 into google-deepmind:main Sep 23, 2024
8 checks passed
@carlosgmartin carlosgmartin deleted the test_sh_jax_version_unset branch September 23, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants