Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nesterov momentum to AdaBelief optimizer. #1127

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Add Nesterov momentum to AdaBelief optimizer. #1127

merged 1 commit into from
Nov 4, 2024

Conversation

carlosgmartin
Copy link
Contributor

Add Nesterov momentum to the AdaBelief optimizer. This commit adds the same code that scale_by_adam uses to compute mu_hat when nesterov=True to scale_by_belief.

fabianp
fabianp approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@fabianp fabianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@copybara-service copybara-service bot merged commit a8a06eb into google-deepmind:main Nov 4, 2024
8 checks passed
@carlosgmartin carlosgmartin deleted the adabelief_nesterov branch November 4, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianp fabianp fabianp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosgmartin @fabianp