Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Version 1.0] Support for automatically downloading RETVec embedding model from Keras Applications + small fixes in preperation for v1 release #16

Merged
merged 5 commits into from
Jun 30, 2023
Merged

[Version 1.0] Support for automatically downloading RETVec embedding model from Keras Applications + small fixes in preperation for v1 release #16

merged 5 commits into from
Jun 30, 2023

Conversation

MarinaZhang
Copy link
Collaborator

This CL contains the following changes:

  • Adds support for auto-downloading RETVec v1 model from Keras applications GCP bucket
  • Remove broken classifiers in setup.py
  • Version change to 1.0.0 since we uploaded the RETVec v1 model

@MarinaZhang MarinaZhang self-assigned this Jun 6, 2023
@MarinaZhang MarinaZhang added the enhancement New feature or request label Jun 6, 2023
@MarinaZhang MarinaZhang linked an issue Jun 6, 2023 that may be closed by this pull request
Upload RETVec embedding model to Keras applications and offer an option to auto-download the model weights #17
Closed
@ebursztein
Copy link
Collaborator

Works for me but we need hash of the files for security -- please add those sha256 commandline should work

@ebursztein ebursztein merged commit ce35112 into main Jun 30, 2023
@MarinaZhang MarinaZhang deleted the marinazh/keras_applications_download_refactor branch July 12, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebursztein ebursztein ebursztein approved these changes

@owenvallis owenvallis Awaiting requested review from owenvallis

Assignees

@MarinaZhang MarinaZhang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload RETVec embedding model to Keras applications and offer an option to auto-download the model weights
2 participants
@MarinaZhang @ebursztein