Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Bump clang-format@16 → 17 #127

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[Infra] Bump clang-format@16 → 17 #127

merged 1 commit into from
Sep 19, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Sep 19, 2023

No description provided.

@ncooke3
Copy link
Member Author

ncooke3 commented Sep 19, 2023

style CI might fail because firebase/firebase-ios-sdk#11824 is not landed yet

andrewheard
andrewheard approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will ping as soon as the PR in firebase-ios-sdk lands.

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

No changes between base commit (1426609) and merge commit (4aff963).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/d5rVUp4QK3.html

@andrewheard andrewheard merged commit 1a4c036 into main Sep 19, 2023
20 checks passed
@andrewheard andrewheard deleted the nc/clang17 branch September 19, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @google-oss-bot @andrewheard