Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large blobs #263

Merged
merged 12 commits into from
Jan 25, 2021
Merged

Large blobs #263

merged 12 commits into from
Jan 25, 2021

Conversation

kaczmarczyck
Copy link
Collaborator

This PR implements the LargeBlobs command. It is based on #256 right now, and will be rebased on top of develop after #256 is merged.
All work is in this commit. It is pushed here as a preview and to discuss how to best access the storage. The goal is to end up with an implementation of this command that is functionally equivalent, but more efficient in how it gets and commits the data.

  • Tests pass

@kaczmarczyck kaczmarczyck requested a review from ia0 January 20, 2021 11:17
@kaczmarczyck kaczmarczyck self-assigned this Jan 20, 2021
@google-cla google-cla bot added the cla: yes label Jan 20, 2021
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
@kaczmarczyck kaczmarczyck changed the base branch from stable to develop January 20, 2021 14:02
@kaczmarczyck
Copy link
Collaborator Author

I'll rebase as announced now, then work on the transactions.

src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
ia0
ia0 previously approved these changes Jan 25, 2021
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at storage.

src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
src/ctap/storage.rs Outdated Show resolved Hide resolved
@kaczmarczyck kaczmarczyck reopened this Jan 25, 2021
@kaczmarczyck kaczmarczyck merged commit 0f85470 into google:develop Jan 25, 2021
@kaczmarczyck kaczmarczyck deleted the large-blobs branch January 25, 2021 20:45
@kaczmarczyck kaczmarczyck mentioned this pull request Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants