Remove duplicated alarm syscall. #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alarm syscall is implemented in libtock-rs, but was duplicated here. This removes the duplicated code and changes the references to point to libtock-rs directly.
ia0
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
I tested on webauthn (register, login, reset, login) and it works.
However, I was able to generate a panic too (but unrelated to this PR):
panicked at 'assertion failed: self.pending_out.take()', capsules/src/usb/usbc_ctap_hid.rs:364:17
I don't really have reproduction steps because it looks like a timing issue. Here are the steps I'm taking:
- Have a nordic dev board with opensk and another security key (U2F only) connected (not sure it matters, but that's the setup)
- Register both.
- Authenticate repeatedly (cancelling the popup and not touching any key)
- The dev board will eventually panic when clicking Authenticate (not when cancelling the popup)
kaczmarczyck
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
If @ia0 's panic is unrelated to the PR, feel free to merge. We can always test and fix it more later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alarm syscall is implemented in libtock-rs, but was duplicated here. This removes the duplicated code and changes the references to point to libtock-rs directly.