Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.md to add correct board type #651

Closed
wants to merge 1 commit into from

Conversation

iayanpahwa
Copy link

Change board from nrf52840dk to nrf52840dk_opensk

Fixes #650

Change board from nrf52840dk to nrf52840dk_opensk
@google-cla
Copy link

google-cla bot commented Sep 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but the stable branch does not have an nrf52840dk_opensk board. This is specific to the develop branch. And the documentation there is up-to-date. By default on Github shows you the stable branch which may be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong board type in flashing command in install.md
2 participants