Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest compiler and package versions #663

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Latest compiler and package versions #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
580ff83
Move to latest compiler and package versions
kaczmarczyck Nov 9, 2023
43a3ffd
Install cargo audit differently in workflow
kaczmarczyck Nov 9, 2023
f3b7ade
Removes leftover nightly references
kaczmarczyck Nov 9, 2023
207e86f
Removes install check from deploy.py
kaczmarczyck Nov 9, 2023
391f992
Removes rust component install from workflow
kaczmarczyck Nov 9, 2023
93137d4
Moves cargo audit install to setup.sh
kaczmarczyck Nov 9, 2023
2d0aba5
Updates cargo bloat workflow to default features
kaczmarczyck Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cargo_bloat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Binary size report

Check notice on line 1 in .github/workflows/cargo_bloat.yml

View workflow job for this annotation

GitHub Actions / cargo_bloat

Binary size 


OLD 118.3 kiB
NEW 114.5 kiB

Output of cargo bloat
======================

Including PR
 File  .text     Size Crate
13.3%  46.5%  53.2KiB opensk
 4.4%  15.3%  17.5KiB ctap2
 3.9%  13.7%  15.7KiB std
 2.5%   8.8%  10.1KiB crypto
 1.9%   6.8%   7.7KiB persistent_store
 1.1%   4.0%   4.5KiB sk_cbor
 0.7%   2.4%   2.8KiB [Unknown]
 0.1%   0.5%     606B libtock_drivers
 0.1%   0.5%     572B linked_list_allocator
 0.1%   0.5%     562B lang_items
 0.1%   0.4%     412B libtock_runtime
 0.1%   0.3%     368B libtock_platform
 0.1%   0.3%     338B subtle
 0.0%   0.1%      72B byteorder
 0.0%   0.0%      20B libtock_buttons
 0.0%   0.0%      20B zeroize
28.6% 100.0% 114.5KiB .text section size, the file size is 400.1KiB


Base branch
 File  .text     Size Crate
13.2%  46.3%  54.8KiB opensk
 4.3%  15.2%  17.9KiB ctap2
 4.2%  14.5%  17.2KiB std
 2.4%   8.5%  10.0KiB crypto
 1.9%   6.6%   7.8KiB persistent_store
 1.1%   3.8%   4.5KiB sk_cbor
 0.8%   2.7%   3.2KiB [Unknown]
 0.2%   0.5%     658B libtock_drivers
 0.2%   0.5%     636B linked_list_allocator
 0.1%   0.5%     550B lang_items
 0.1%   0.3%     374B libtock_platform
 0.1%   0.3%     360B subtle
 0.0%   0.1%     112B libtock_runtime
 0.0%   0.0%      44B byteorder
 0.0%   0.0%      26B libtock_buttons
 0.0%   0.0%      20B zeroize
28.6% 100.0% 118.3KiB .text section size, the file size is 413.9KiB
on: pull_request

jobs:
Expand All @@ -21,7 +21,7 @@
- name: Set up OpenSK
run: ./setup.sh
- name: Run bloat on the PR
run: RUSTFLAGS="-C link-arg=-icf=all -C force-frame-pointers=no -C link-arg=-Tnrf52840_layout.ld" cargo bloat --release --target=thumbv7em-none-eabi --features=with_ctap1,vendor_hid --crates >> .github/workflows/bloat_output_new.txt
run: RUSTFLAGS="-C link-arg=-icf=all -C force-frame-pointers=no -C link-arg=-Tnrf52840_layout.ld" cargo bloat --release --target=thumbv7em-none-eabi --features=config_command,with_ctap1 --crates >> .github/workflows/bloat_output_new.txt

# Second run: PR
- uses: actions/checkout@v2
Expand All @@ -34,7 +34,7 @@
run: ./setup.sh
- name: Run bloat on base
working-directory: ./OpenSK_base
run: RUSTFLAGS="-C link-arg=-icf=all -C force-frame-pointers=no -C link-arg=-Tnrf52840_layout.ld" cargo bloat --release --target=thumbv7em-none-eabi --features=with_ctap1,vendor_hid --crates >> "$GITHUB_WORKSPACE/.github/workflows/bloat_output_old.txt"
run: RUSTFLAGS="-C link-arg=-icf=all -C force-frame-pointers=no -C link-arg=-Tnrf52840_layout.ld" cargo bloat --release --target=thumbv7em-none-eabi --features=config_command,with_ctap1 --crates >> "$GITHUB_WORKSPACE/.github/workflows/bloat_output_old.txt"

- name: Run output formatter to echo workflow command
run: ./.github/workflows/bloat_formatter.sh bloat_output_new.txt bloat_output_old.txt bloat_comment.md
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,4 @@ jobs:
with:
python-version: "3.10"
- run: ./setup.sh
- run: rustup component add rustfmt --toolchain nightly
- run: rustup component add clippy --toolchain nightly
- run: ./run_desktop_tests.sh
Loading
Loading