Removes the dependabot version update config #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this commit is to enable security updates. Before, security updates were prevented because they followed the config. We didn't benefit from version updates so far because of this same file, and we don't want them. While 2.1 is our main branch, version updates make even less sense, since we want to keep it stable.
ia0
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
The dependabot configuration had at least the following issues:
- Using
directory: "/"only enables version updates for the top-level crate (i.e. not for any of the libraries). - The configuration applies to both version updates and security updates, so indirect dependencies and patch updates would not create a dependabot PR for both version and security updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this commit is to enable security updates. Before, security updates were prevented because they followed the config.
We didn't benefit from version updates so far because of this same file, and we don't want them. While 2.1 is our main branch, version updates make even less sense, since we want to keep it stable.