Aways return geographic coordinates from ee.Geometry.bounds() #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
Aways return geographic coordinates from
ee.Geometry.bounds()
because the later call topyproj.Transformer.from_crs
to get coordinates in the requestedcrs
is expecting geographic (lat lon) coordinates. If aprojection
argument is provided, the current implementation wrongly returns the bounds of the request in the crs of the projection, it should be in EPSG:4326, which is what happens if a person specifiescrs
andscale
instead ofprojection
becauseself.projection
is never set in this case and thereforeee.Geometry.bounds()
defaults toEPSG:4326
, which is fine.See #198 for a repro/testing script.