Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aways return geographic coordinates from ee.Geometry.bounds() #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdbcode
Copy link
Member

@jdbcode jdbcode commented Dec 18, 2024

Fixes #198

Aways return geographic coordinates from ee.Geometry.bounds() because the later call to pyproj.Transformer.from_crs to get coordinates in the requested crs is expecting geographic (lat lon) coordinates. If a projection argument is provided, the current implementation wrongly returns the bounds of the request in the crs of the projection, it should be in EPSG:4326, which is what happens if a person specifies crs and scale instead of projection because self.projection is never set in this case and therefore ee.Geometry.bounds() defaults to EPSG:4326, which is fine.

See #198 for a repro/testing script.

@jdbcode jdbcode requested a review from naschmitz December 18, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when providing a projected CRS to the projection parameter
1 participant