Skip to content

Commit

Permalink
create-gaarf-wf@1.5.4: putting a generated link for cloning a dashboa…
Browse files Browse the repository at this point in the history
…rd into dashboard_url.txt file

gaarf-js@1.11.2: `bq.project` is made non-mandatory

Change-Id: I3b1dd063b6de98a8d02a42e0c99299cabd866f77
  • Loading branch information
evil-shrike committed Feb 28, 2023
1 parent 26b8f8e commit 9bbb2fb
Show file tree
Hide file tree
Showing 10 changed files with 24 additions and 24 deletions.
3 changes: 2 additions & 1 deletion gcp/create-gaarf-wf/build/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gcp/create-gaarf-wf/build/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions gcp/create-gaarf-wf/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gcp/create-gaarf-wf/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-gaarf-wf",
"version": "1.5.3",
"version": "1.5.4",
"description": "Interactive generator for Gaarf (Google Ads API Report Fetcher) Workflow",
"type": "module",
"bin": {
Expand Down
3 changes: 2 additions & 1 deletion gcp/create-gaarf-wf/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -501,9 +501,10 @@ async function deploy_dashboard(
datasources
);
console.log(
'As soon as your workflow completes successfully, open the following link in the browser for cloning template dashboard:'
'As soon as your workflow completes successfully, open the following link in the browser for cloning template dashboard (you can find it inside dashboard_url.txt):'
);
console.log(chalk.cyanBright(dashboard_url));
fs.writeFileSync('dashboard_url.txt', dashboard_url);
}

async function initialize_googleads_config(answers: Partial<any>) {
Expand Down
13 changes: 6 additions & 7 deletions js/dist/cli.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion js/dist/cli.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion js/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "google-ads-api-report-fetcher",
"version": "1.11.1",
"version": "1.11.2",
"description": "Google Ads API Report Fetcher (gaarf)",
"main": "./dist/index.js",
"types": "./src/index.ts",
Expand Down
13 changes: 6 additions & 7 deletions js/src/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -238,19 +238,18 @@ function getWriter(): IResultWriter {
// TODO: move all options to BigQueryWriterOptions
if (!argv.bq) {
throw new Error(
`For BigQuery writer (---output=bq) we should specify at least a project and a dataset id`);
}
let projectId = (<any>argv.bq).project
let dataset = (<any>argv.bq).dataset;
if (!projectId) {
console.warn(`bq.project option should be specified (GCP project id)`);
process.exit(-1);
`For BigQuery writer (---output=bq) we should specify at least a dataset id`);
}
const dataset = (<any>argv.bq).dataset;
if (!dataset) {
console.warn(
`bq.dataset option should be specified (BigQuery dataset id)`);
process.exit(-1);
}
const projectId = (<any>argv.bq).project;
if (!projectId) {
console.warn(`GCP project id was not specified explicitly (bq.project option), so we're using the current default project`);
}
let opts: BigQueryWriterOptions = {};
let bq_opts = <any>argv.bq;
opts.datasetLocation = bq_opts.location;
Expand Down

0 comments on commit 9bbb2fb

Please sign in to comment.