Fail fast while fetching GoogleAds reports #16
Closed
yershovkiril
started this conversation in
Ideas
Replies: 1 comment
-
|
Fixed - https://github.com/google/ads-api-report-fetcher/blob/main/py/gaarf/query_executor.py#L95 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently AdsReportFetcher is handling any GoogleAdsException while loading data by just printing error to the log, so we can't be really confident that data is fully loaded.
Please consider introducing some additional flag, so that I can enforce failing of the loader in case of issues with loading.
ads-api-report-fetcher/py/gaarf/query_executor.py
Line 86 in 9bbb2fb
Beta Was this translation helpful? Give feedback.
All reactions