Add a workflow to create release build. #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snehasish
reviewed
Jul 19, 2024
| - name: Configure CMake | ||
| # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make. | ||
| # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type | ||
| run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DENABLE_TOOL=LLVM -S ${{github.workspace}} |
There was a problem hiding this comment.
I think this will default to using g++ as the compiler. Is that desired?
There was a problem hiding this comment.
This can be built with clang toolchain too, either works. Except for clang, we need to install necessary packages in the previous step.
There was a problem hiding this comment.
I think we should build the release binaries with clang to minimize surprises. Also the runner should already have clang-13 [1] on it so it's not necessary to install clang as a package.
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
There was a problem hiding this comment.
Thanks. I will add -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ and test build on my personal repo.
snehasish
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR setup a workflow to create a release build. Below is the steps to create a release
git tag <tag_name>git push <repo> tag <tag_name>This workflow can also be manually triggered to create a release for older versions.
The workflow shall be further improved so that we can create the release on the github webpage and let it trigger the release build.