[NFC] Simplify window size handling #438
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apazylbe
reviewed
Feb 26, 2024
apazylbe
reviewed
Mar 11, 2024
apazylbe
reviewed
Apr 17, 2024
This change is the first requirement for cleaning up knobs initialization: BigWheels has settings, which are used to initialize default values, which in turn are used to initialize knobs. But then those settings becomes RW values used at runtime (like window.width, window.height). The ultimate goal is to sanitize this whole initialization step, and only rely on knobs. This first commit removes `window.width` and `window.height` from the settings, and rely on the `Window` class to store its size. This should be a NFC.
|
Rebased on main to fix the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is the first requirement for cleaning up knobs initialization:
BigWheels has settings, which are used to initialize default
values, which in turn are used to initialize knobs. But then those
settings becomes RW values used at runtime (like window.width,
window.height).
The ultimate goal is to sanitize this whole initialization step, and
only rely on knobs.
This first commit removes
window.widthandwindow.heightfrom the settings, and rely on theWindowclass to store its size. This should be a NFC.Tested on linux, android and Windows. The swapchain is only resized once on window size change (checked on windows, setting the window to fullscreen etc)