This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Ability to set a zoom factor from xml or programmatically #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it |
|
CLAs look good, thanks! |
# Conflicts: # library/src/main/api14/com/google/android/cameraview/Camera1.java
Closed
# Conflicts: # demo/src/main/res/layout/include_camera.xml
|
Any updates? |
# Conflicts: # demo/src/main/res/layout/include_camera.xml # library/src/main/api14/com/google/android/cameraview/Camera1.java
ewolfox
pushed a commit
to ewolfox/cameraview
that referenced
this pull request
Apr 13, 2018
* Added a maximum file size for videos * Revereted changes to the onVideoTaken callback signature * Renamed isRecordingVideo, added xml attribute for video max size and updated the documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed the functionality to set a specific zoom factor for the cameraview. The code can also be used to implement a pinch zoom.
Furthermore camera shows the picture that was taken before user can resume the preview.
We hope that our changes can be integrated in the master branch. If you have any issues with the code, we can adjust it accordingly.