Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NNX #3218

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Add NNX #3218

merged 1 commit into from
Nov 9, 2023

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Jul 21, 2023

What does this PR do?

Adds cgarciae/nnx as an experimental submodule from Flax:

from flax.experimental import nnx

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cgarciae cgarciae marked this pull request as ready for review July 24, 2023 18:37
@cgarciae cgarciae changed the title add NNX Add NNX Jul 24, 2023
@cgarciae cgarciae marked this pull request as draft October 20, 2023 15:41
@cgarciae cgarciae marked this pull request as ready for review November 7, 2023 15:04
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #3218 (8e9df27) into main (cbf7bea) will decrease coverage by 31.46%.
Report is 10 commits behind head on main.
The diff coverage is 86.31%.

@@             Coverage Diff             @@
##             main    #3218       +/-   ##
===========================================
- Coverage   83.62%   52.16%   -31.46%     
===========================================
  Files          56       91       +35     
  Lines        6790    10954     +4164     
===========================================
+ Hits         5678     5714       +36     
- Misses       1112     5240     +4128     
Files Coverage Δ
flax/experimental/nnx/__init__.py 100.00% <100.00%> (ø)
flax/experimental/nnx/nnx/errors.py 100.00% <100.00%> (ø)
flax/experimental/nnx/nnx/nn/activations.py 100.00% <100.00%> (ø)
flax/experimental/nnx/tests/test_compatibility.py 100.00% <100.00%> (ø)
flax/experimental/nnx/tests/test_containers.py 100.00% <100.00%> (ø)
flax/experimental/nnx/tests/test_helpers.py 100.00% <100.00%> (ø)
flax/experimental/nnx/tests/test_ids.py 100.00% <100.00%> (ø)
flax/experimental/nnx/tests/test_integration.py 100.00% <100.00%> (ø)
flax/experimental/nnx/tests/test_partitioning.py 100.00% <100.00%> (ø)
flax/experimental/nnx/tests/test_rngs.py 100.00% <100.00%> (ø)
... and 27 more

... and 41 files with indirect coverage changes

@copybara-service copybara-service bot merged commit 77b7e03 into main Nov 9, 2023
21 checks passed
@copybara-service copybara-service bot deleted the nnx branch November 9, 2023 18:36
@8bitmp3
Copy link
Collaborator

8bitmp3 commented Nov 10, 2023

🚀 @cgarciae @levskaya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants