make flax.core.copy add_or_replace optional
#3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore .envrc (direnv files) format add test fix
cgarciae
reviewed
Aug 1, 2023
cgarciae
reviewed
Aug 1, 2023
cgarciae
reviewed
Aug 1, 2023
flax/core/frozen_dict.py
Outdated
Comment on lines
251
to
252
| if add_or_replace is not None: | ||
| new_dict.update(add_or_replace) |
There was a problem hiding this comment.
Suggested change
| if add_or_replace is not None: | |
| new_dict.update(add_or_replace) | |
| if isinstance(add_or_replace, dict): | |
| add_or_replace = jax.tree_map(lambda x: x, add_or_replace) | |
| new_dict.update(add_or_replace) |
There was a problem hiding this comment.
I'm not sure I understand the logic here.
Using your MappingProxy idea, I can just remove this change, and wouldn't need to touch those lines.
|
Thanks @PhilipVinc! Added some suggestions. cc @chiamp |
Co-authored-by: Cristian Garcia <cgarcia.e88@gmail.com>
|
thanks @cgarciae . I implemented your suggestions except for the one above where I just removed by edits. Let me know if this looks good for you. |
|
This looks great, thanks @PhilipVinc! |
chiamp
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes the API easier to use when you just want to have a copy of a dictionary.