Explicitly export "struct" from module "flax". #3249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_552452298
branch
from
458368c
to
1d4ac5a
Compare
copybara-service
bot
force-pushed
the
test_552452298
branch
from
1d4ac5a
to
bb1902b
Compare
copybara-service
bot
force-pushed
the
test_552452298
branch
2 times, most recently
from
4dab697
to
7c81f51
Compare
cgarciae
approved these changes
Aug 16, 2023
This allows the following: ``` import flax @flax.struct.dataclass class C: ... ``` The current usages of the above pattern in flax only work accidentally because there already are imports for "flax.struct" in other files. See also https://docs.python.org/3/reference/simple_stmts.html#the-import-statement PiperOrigin-RevId: 552452298
copybara-service
bot
force-pushed
the
test_552452298
branch
from
7c81f51
to
deca5e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly export "struct" from module "flax".
This allows the following:
The current usages of the above pattern in flax only work
accidentally because there already are imports for "flax.struct"
in other files.
See also https://docs.python.org/3/reference/simple_stmts.html#the-import-statement