Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore previous _compute_stats behavior in local case. #3266

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

Restore previous _compute_stats behavior in local case.

Some earlier code refactors introduced a concat+split "no-op" to the non-distributed codepath
that turns out not to be such a no-op and can cause issues in some compiled code. We polish
the refactor a bit to avoid this introduced change.

@copybara-service copybara-service bot force-pushed the test_554682671 branch 6 times, most recently from cafb5ad to e6d0e97 Compare August 9, 2023 01:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #3266 (e6d0e97) into main (fe54d39) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #3266      +/-   ##
==========================================
- Coverage   82.35%   82.34%   -0.01%     
==========================================
  Files          54       54              
  Lines        6092     6095       +3     
==========================================
+ Hits         5017     5019       +2     
- Misses       1075     1076       +1     
Files Changed Coverage Δ
flax/linen/normalization.py 96.89% <91.66%> (-0.58%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant