-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add find
methods and magic methods for Cursor API
#3306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3306 +/- ##
==========================================
+ Coverage 82.65% 83.01% +0.36%
==========================================
Files 55 55
Lines 6359 6518 +159
==========================================
+ Hits 5256 5411 +155
- Misses 1103 1107 +4
|
cgarciae
reviewed
Sep 7, 2023
cgarciae
reviewed
Sep 7, 2023
chiamp
force-pushed
the
cursor_find
branch
9 times, most recently
from
September 8, 2023 23:17
38a080d
to
0f2e326
Compare
chiamp
changed the title
Add find feature for Cursor API
Add Sep 8, 2023
find
methods and magic methods for Cursor API
chiamp
force-pushed
the
cursor_find
branch
2 times, most recently
from
September 11, 2023 20:47
336bcfa
to
7a23f8d
Compare
cgarciae
reviewed
Sep 11, 2023
cgarciae
reviewed
Sep 11, 2023
cgarciae
reviewed
Sep 11, 2023
cgarciae
reviewed
Sep 11, 2023
cgarciae
reviewed
Sep 11, 2023
cgarciae
reviewed
Sep 11, 2023
cgarciae
reviewed
Sep 11, 2023
marcvanzee
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Cursor PR: #3246
Resolves #3309 and resolves #3311.
The PR adds the following features to the Cursor API:
Cursor.obj -> Cursor._obj
).find_all
method which finds all child Cursor objects that fulfill acond_fn
that is passed into the method.find
method which finds a single child Cursor object that fulfills acond_fn
passed into the method. An error is raised if no object or more than one object is found.._path
property for Cursor objects