Upgrade Flax NNX Filters doc #4199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
8bitmp3
force-pushed
the
upgrade-nnx-filters
branch
from
cea5fb0
to
2d64500
Compare
8bitmp3
force-pushed
the
upgrade-nnx-filters
branch
from
57a361e
to
239c9de
Compare
8bitmp3
force-pushed
the
upgrade-nnx-filters
branch
from
ef24a1e
to
7c5afdb
Compare
8bitmp3
force-pushed
the
upgrade-nnx-filters
branch
2 times, most recently
from
a73e710
to
e5586f4
Compare
8bitmp3
force-pushed
the
upgrade-nnx-filters
branch
from
e5586f4
to
a0a19ed
Compare
cgarciae
reviewed
Oct 23, 2024
| @@ -31,28 +37,29 @@ print(f'{params = }') | |||
| print(f'{batch_stats = }') | |||
| ``` | |||
|
|
|||
| Here `nnx.Param` and `nnx.BatchStat` are used as Filters to split the model into two groups: one with the parameters and the other with the batch statistics. However, this begs the following questions: | |||
There was a problem hiding this comment.
I don't agree removing this explanation. Can you explain why its removed?
There was a problem hiding this comment.
This was not removed - it's above the code block on line 22. LMKWYT.
In the following example [`nnx.Param`](https://flax.readthedocs.io/en/latest/api_reference/flax.nnx/variables.html#flax.nnx.Param)
and [`nnx.BatchStat`](https://flax.readthedocs.io/en/latest/api_reference/flax.nnx/variables.html#flax.nnx.BatchStat)
are used as `Filter`s to split the model into two groups: one
with the parameters and the other with the batch statistics:
```{code-cell} ipython3
from flax import nnx
class Foo(nnx.Module):
def __init__(self):
self.a = nnx.Param(0)
self.b = nnx.BatchStat(True)
foo = Foo()
graphdef, params, batch_stats = nnx.split(foo, nnx.Param, nnx.BatchStat)
print(f'{params = }')
print(f'{batch_stats = }')
@cgarciae
8bitmp3
commented
Oct 23, 2024
| @@ -8,12 +8,18 @@ jupytext: | |||
| jupytext_version: 1.13.8 | |||
| --- | |||
|
|
|||
| # Using Filters | |||
| # Using `Filter`s | |||
There was a problem hiding this comment.
Can remove codefont Markdown formatting from section titles similar to Flax Basics @cgarciae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.