Add NNX transforms nnx.while_loop and nnx.switch
#4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvyZX
force-pushed
the
conds
branch
3 times, most recently
from
c0e6ba2
to
338bfb8
Compare
8bitmp3
reviewed
Oct 30, 2024
cgarciae
reviewed
Oct 31, 2024
flax/nnx/transforms/transforms.py
Outdated
| global_index_mapping = {} | ||
| if not isinstance(ns, extract.NodeStates): | ||
| return ns | ||
| assert isinstance(ns._graphdef, graph.NodeDef) |
There was a problem hiding this comment.
When you have a repeated NNX object in the pytree processed by to_tree you will get a NodeRef here. I tested this example that fails (can we add it to the test cases?).
def test_repeated_object(self):
m = nnx.Linear(10, 10, rngs=nnx.Rngs(0))
def body_fn(val):
count, m, _ = val
return count + 1, m, m
count, m, _ = nnx.while_loop(
lambda val: val[0] < 2,
body_fn,
(0, m, m),
)To fix it you can probably just return.
Suggested change
| assert isinstance(ns._graphdef, graph.NodeDef) | |
| if not isinstance(ns._graphdef, graph.NodeDef): | |
| return ns |
There was a problem hiding this comment.
Great catch, thanks!
cgarciae
reviewed
Oct 31, 2024
flax/nnx/transforms/transforms.py
Outdated
| def per_node_state(ns: extract.NodeStates | tp.Any): | ||
| if not isinstance(ns, extract.NodeStates): | ||
| return ns | ||
| assert isinstance(ns._graphdef, graph.NodeDef) |
cgarciae
reviewed
Oct 31, 2024
flax/nnx/transforms/transforms.py
Outdated
| init_val: T) -> T: | ||
| """NNX transform of `jax.lax.while_loop`. | ||
|
|
||
| See: https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.while_loop.html |
There was a problem hiding this comment.
More friendly link.
Suggested change
| See: https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.while_loop.html | |
| See `jax.lax.while_loop <https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.while_loop.html>`_. |
There was a problem hiding this comment.
Or maybe we link be above mention?
cgarciae
reviewed
Oct 31, 2024
flax/nnx/transforms/transforms.py
Outdated
| """NNX transform of `jax.lax.while_loop`. | ||
|
|
||
| See: https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.while_loop.html | ||
|
|
There was a problem hiding this comment.
Can we add a simple example usage here?
cgarciae
approved these changes
Oct 31, 2024
|
BTW: Can we move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
nnx.switchsimilar tonnx.condImplemented
nnx.while_loopjax.lax.while_loop, no reference structure change is allowed insidennx.while_loopfor NNX objects.