Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GestureDetector onPanDown to Listener onPointerDown #426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asjqkkkk
Copy link
Contributor

Description

to solve #425

before

        return GestureDetector(
          onPanDown: (_) => _stopScroll(canceled: true),
          excludeFromSemantics: true,

now

        return Listener(
          onPointerDown: (_) => _stopScroll(canceled: true),

onPanDown of GestureDetector will get a conflict with some widgets, such as SelectionArea
use Listener can solve this issue

Related Issues

#425

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I signed the CLA.
  • All tests from running flutter test pass.
  • flutter analyze does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

@google-cla
Copy link

google-cla bot commented Sep 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@asjqkkkk asjqkkkk changed the title fix: #425 Change GestureDetector onPanDown to Listener onPointerDown Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant