[scrollable_positioned_list] Fixed cacheExtent value for horizontal list #453
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarobins
added a commit
to tarobins/flutter.widgets
that referenced
this pull request
Apr 26, 2023
tarobins
added a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scrollTodoes not work on horizontal lists as accurately and efficiently as it does vertical lists. This problem also occurs in horizontal lists because thecacheExtentvalue is set based on the maximum height. To fix this situation, I fixed thecacheExtentvalue to be created withmaxWidthin horizontal lists.Related Issues
TODO
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.flutter testpass.flutter analyzedoes not report any problems on my PR.