Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check operator fix when items in ScrollablePositionedList are created/deleted dynamically #512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hwkim1127
Copy link

@hwkim1127 hwkim1127 commented Jan 4, 2024

This fixes "Unhandled Exception: Null check operator used on a null value" when items in the ScrollablePositionedList are dynamically created or deleted.

Description

Currently, when items in ScrollablePositionedList are created dynamically(created or deleted), jumpTo has "!" which indicates that the scrollableListState exists, but this is not the case when items inside ScrollablePositionedList are created or deleted dynamically.

This is a simple fix which replaces "!" to "?"

Related Issues

Throws and exception(Unhandled Exception: Null check operator used on a null value) each time items for ScrollablePositionedList are created or deleted dynamically.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I signed the CLA.
  • All tests from running flutter test pass.
  • flutter analyze does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

This fixes "Unhandled Exception: Null check operator used on a null value" when items in the ScrollablePositionedList are dynamically created or deleted.
Copy link

google-cla bot commented Jan 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant