fix: change hello_world cmake compiler use -std=c++17 #116
Conversation
Signed-off-by: weedge <weege007@gmail.com>
Signed-off-by: weedge <weege007@gmail.com>
examples/hello_world/run.cc
Outdated
| @@ -37,7 +37,7 @@ std::vector<int> tokenize( | |||
| return tokens; | |||
| } | |||
|
|
|||
| int main(int argc, char** argv) { | |||
| int main(int argc, const char** argv) { | |||
There was a problem hiding this comment.
Why do we use const here? char** or char*[] is standard, see 3.6.1 in https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3337.pdf.
There was a problem hiding this comment.
argv from command params just read, so want use const char**, want use libgemma util/app.h this function gcpp::LoaderArgs loader(argc, argv) i want to cast const char** to char** , like this char** nonConstPtr = const_cast<char*>(constPtr);; but this command argv is immutable
There was a problem hiding this comment.
Why do we use const here? char** or char*[] is standard, see 3.6.1 in https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3337.pdf.
use main(int argc, char** argv) it's ok~
Signed-off-by: weedge <weege007@gmail.com>
Signed-off-by: weedge <weege007@gmail.com>
examples/hello_world/run.cc
Outdated
| @@ -38,7 +38,7 @@ std::vector<int> tokenize( | |||
| } | |||
|
|
|||
| int main(int argc, char** argv) { | |||
| gcpp::LoaderArgs loader(argc, argv); | |||
| gcpp::LoaderArgs loader(argc, (const char**)argv); | |||
There was a problem hiding this comment.
I still do not understand how this change is helpful? :) Const is generally helpful, but for historical reasons we are stuck with non-const for args. It seems like casting is worse than the safety benefit.
We can keep the c++17 change, but let's revert the const or at least move to a separate PR to discuss further :)
Signed-off-by: weedge <weege007@gmail.com>
Signed-off-by: weedge <weege007@gmail.com>
weedge
changed the title
jan-wassenberg
added
the
copybara-import
|
We have an issue with the copybara import mechanism. Working on it. |
jan-wassenberg
added
copybara-import
|
Hi @weedge, sorry this has taken so long. Would you mind rebasing? |
use libgemma util/app.h this function
gcpp::LoaderArgs loader(argc, argv), Want to pass const char** to argv