[demos][python] Add a new Python PaLM demo: Docs Agent #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc Agents allows PaLM API users to launch a chat application using their own documents as a dataset.
github-actions
bot
added
the
status:awaiting review
- Create a symlink to the Docs Agent project's `third_party` directory.
instructions in README.md
directories in the setup instructions.
markmcd
requested changes
Sep 15, 2023
There was a problem hiding this comment.
Left a few basic comments. I didn't go over anything in detail, just spot checked a couple things and mainly checked the licenses.
Can you please include ownership changes in /CODEOWNERS and set up your unit test instrumentation too - can be another PR if you like, but please do it ASAP (e.g. no CODEOWNERS means we have to manually triage any PRs / issues that are filed).
demos/palm/python/docs-agent/scripts/populate_vector_database.py
Outdated
Show resolved
Hide resolved
- Replace the `CONTRIBUTING.md` with Google's official one. - Updated `REDAME.md` to adjust a link, edit a section, and include contributors. - Run `black` on the `populate_vector_database.py` script. - Update `CODEOWNERS`
kyolee415
commented
Sep 15, 2023
github-actions
bot
removed
the
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc Agents allows PaLM API users to launch a chat application using their own documents as a dataset.