Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing .vscode/ dir for Pipet. #161

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

markmcd
Copy link
Member

@markmcd markmcd commented Oct 19, 2023

Turns out we were excluding .vscode directories in the project's top-level .gitignore file, so remove that an add the missing files.

Motivation

Bugfix

Type of change

Choose one: Bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@markmcd markmcd requested review from shilpakancharla and a team as code owners October 19, 2023 00:23
@markmcd markmcd requested review from shilpakancharla and removed request for shilpakancharla October 19, 2023 00:23
.gitignore Outdated Show resolved Hide resolved
We intentionally ignore `.vscode/` dirs, but in this case we want them
to bootstrap the run/debug workflow.
@markmcd markmcd requested a review from joefernandez as a code owner October 20, 2023 03:46
@markmcd markmcd merged commit 13372ab into google:main Oct 20, 2023
2 checks passed
@markmcd markmcd deleted the fix-ignore branch October 20, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants