Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clustering_with_embeddings.ipynb #393

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Update clustering_with_embeddings.ipynb #393

merged 2 commits into from
Apr 30, 2024

Conversation

JosBecker
Copy link
Contributor

Changed relative links to URLs

Description of the change

Changed relative links to full URLs

Motivation

Relative links return 404 errors in github

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)
Bug Fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@JosBecker
Update clustering_with_embeddings.ipynb
7a01ed8 
Changed relative links to URLs
@JosBecker JosBecker requested a review from a team as a code owner April 30, 2024 02:37
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Apr 30, 2024
markmcd
markmcd approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the links are fine (with redirects). Feel free to merge or fix, I'm not a cop.

site/en/gemini-api/tutorials/clustering_with_embeddings.ipynb Outdated Show resolved Hide resolved
@markmcd markmcd merged commit fe14415 into main Apr 30, 2024
4 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:documentation Update docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosBecker @markmcd