Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update jax_inference.ipynb to use gemma 2 #500

Merged
merged 1 commit into from
Jul 31, 2024
Merged

update jax_inference.ipynb to use gemma 2 #500

merged 1 commit into from
Jul 31, 2024

Conversation

jethac
Copy link
Contributor

@jethac jethac commented Jul 31, 2024

Description of the change

Update the JAX inference notebook to use Gemma 2 2B instead of Gemma 1.x.

Motivation

Gemma 2 2B launch.

Type of change

Documentation

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@jethac jethac requested a review from a team as a code owner July 31, 2024 09:39
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Jul 31, 2024
markmcd
markmcd approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but I think you need to nbfmt/nblint to clear up some of the extra notebook metadata

site/en/gemma/docs/jax_inference.ipynb Outdated Show resolved Hide resolved
@markmcd markmcd merged commit f7962b0 into google:main Jul 31, 2024
3 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:documentation Update docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jethac @markmcd @gustheman