Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python tutorial improvements (SBM feedback) #507

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Python tutorial improvements (SBM feedback) #507

merged 6 commits into from
Sep 11, 2024

Conversation

Giom-V
Copy link
Contributor

@Giom-V Giom-V commented Aug 5, 2024

Description of the change

Minor improvements (wording, moving embeddings in the advance section...) as per PM feedback

Motivation

To make the tutorial easier to understand by newcomers

Type of change

Documentation

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@Giom-V Giom-V requested review from a team as code owners August 5, 2024 13:55
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Aug 5, 2024
@Giom-V Giom-V merged commit 582e6f8 into google:main Sep 11, 2024
3 checks passed
@Giom-V Giom-V deleted the sbm_feedback branch September 11, 2024 12:36
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Sep 11, 2024
alphachart
alphachart reviewed Oct 9, 2024
View reviewed changes
Copy link

@alphachart alphachart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alphachart alphachart alphachart left review comments

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Assignees
No one assigned
Labels
component:documentation Update docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Giom-V @MarkDaoust @alphachart