Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing "external" link tags #510

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Removing "external" link tags #510

merged 1 commit into from
Aug 9, 2024

Conversation

joefernandez
Copy link
Contributor

  • prospective fix for translation serving failure

Motivation

"external" link tagging is suspected cause of translation serving failure

Type of change

Choose one: Documentation

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@joefernandez
Removing "external" link tags
c776374 
- prospective fix for translation serving failure
@joefernandez joefernandez requested a review from a team as a code owner August 9, 2024 20:46
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Aug 9, 2024
@elisabandy elisabandy merged commit 741ebaf into google:main Aug 9, 2024
5 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisabandy elisabandy elisabandy approved these changes

Assignees

@joefernandez joefernandez

@elisabandy elisabandy

Labels
component:documentation Update docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joefernandez @elisabandy