Merge pull request #17 from shamalip/main

Add a note indicating that corner radius will not show up in screensh…
google · Jan 4, 2024 · e8d41e7 · e8d41e7
2 parents 051a8b4 + 945aa96
commit e8d41e7
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/appwidget-testing/README.md b/appwidget-testing/README.md
@@ -47,6 +47,11 @@ Then, using screenshot testing tool of your choice capture and compare the scree
 activity. For example, following sample uses [Roborazzi](https://github.com/takahirom/roborazzi)
 capture and verify the screenshot.
 
+NOTE: The device and screenshot framework you use should support hardware acceleration and
+`clipToOutline` to see rounded corners. For robolectric, see this
+[issue](https://github.com/robolectric/robolectric/issues/8081#issuecomment-1478137890). When using
+an emulator, you may use Espresso's `captureToBitmap` to ensure that the corner radius is captured.
+
 ```kotlin
 Espresso.onView(ViewMatchers.isRoot())
     .captureRoboImage(

diff --git a/...src/main/java/com/google/android/glance/appwidget/testing/GlanceScreenshotTestActivity.kt b/...src/main/java/com/google/android/glance/appwidget/testing/GlanceScreenshotTestActivity.kt
@@ -41,6 +41,12 @@ import kotlinx.coroutines.runBlocking
  * screenshot tests.
  *
  * See README.md for usage.
+ *
+ * NOTE: The device and screenshot framework you use should support hardware acceleration and
+ * `clipToOutline` to see rounded corners. For robolectric, see
+ * https://github.com/robolectric/robolectric/issues/8081#issuecomment-1478137890.
+ * When using an emulator, you may use Espresso's `captureToBitmap` to ensure that the corner radius
+ * is captured.
  */
 @RequiresApi(Build.VERSION_CODES.O)
 public class GlanceScreenshotTestActivity : Activity() {

diff --git a/sample/src/test/java/com/google/android/glance/tools/testing/SampleGlanceScreenshotTest.kt b/sample/src/test/java/com/google/android/glance/tools/testing/SampleGlanceScreenshotTest.kt
@@ -48,6 +48,11 @@ class SampleGlanceScreenshotTest {
     fun sampleGlanceContent() {
         renderComposable()
 
+        // NOTE: The rendering and screenshot framework you use should support hardware acceleration
+        // and `clipToOutline` to see rounded corners. For robolectric, see this
+        // [issue](https://github.com/robolectric/robolectric/issues/8081#issuecomment-1478137890).
+        // When using an emulator, you may use Espresso's `captureToBitmap` to ensure that the
+        // corner radius is captured.
         captureAndVerifyScreenshot("sample_content")
     }