Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating primitives names in LVS rule deck and its README file #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating primitives names in LVS rule deck and its README file #34

wants to merge 1 commit into from

Conversation

FaragElsayed2
Copy link
Collaborator

@FaragElsayed2 FaragElsayed2 commented Aug 11, 2022 •
edited
Loading

Fixes #1

  • Renaming all primitives with its new name except [resistors / sc_diode] in the following files:
    • globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/gf180mcu.lvs
    • globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/README.md

@FaragElsayed2 FaragElsayed2 changed the title Updating primitives names Updating primitives names part3 Aug 11, 2022
atorkmabrains
atorkmabrains approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithro I'm approving this change.

@FaragElsayed2 FaragElsayed2 changed the title Updating primitives names part3 Updating primitives names in LVS rule deck and its README file Aug 21, 2022
@FaragElsayed2
Copy link
Collaborator Author

FaragElsayed2 commented Aug 31, 2022 •
edited
Loading

@mithro Changes are completed including cap_mim as you agreed with @atorkmabrains

atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Dec 18, 2022
@atorkmabrains
Merge pull request google#34 from efabless/main
218d914 
Update via4.drc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atorkmabrains atorkmabrains atorkmabrains approved these changes

@mithro mithro Awaiting requested review from mithro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the naming of the primitives to be consistent with skywater-pdk format.
2 participants
@FaragElsayed2 @atorkmabrains