Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blob/all: Allow disabling of ContentType auto-detection during writes #3371

Merged
merged 1 commit into from
Dec 21, 2023
Merged

blob/all: Allow disabling of ContentType auto-detection during writes #3371

merged 1 commit into from
Dec 21, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Dec 21, 2023

Fixes #3298.

@vangent vangent mentioned this pull request Dec 21, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dbbbb3) 77.36% compared to head (971a597) 77.37%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3371   +/-   ##
=======================================
  Coverage   77.36%   77.37%           
=======================================
  Files         104      104           
  Lines       13949    13951    +2     
=======================================
+ Hits        10792    10794    +2     
  Misses       2396     2396           
  Partials      761      761

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangent vangent merged commit 4fe95ee into google:master Dec 21, 2023
6 checks passed
@vangent vangent deleted the blankct branch December 21, 2023 05:17
@stanhu
Copy link
Contributor

stanhu commented Dec 21, 2023

@vangent Thanks so much for this!

stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
643f86b 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
@stanhu stanhu mentioned this pull request Feb 23, 2024
Merged
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
8066870 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
53a0705 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 23, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
74b5319 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs
googleapis/google-cloud-go#9431 to work.
`go.mod` has been updated to use pseudo-version until
cloud.google.com/go/storage v1.39 is available
(googleapis/google-cloud-go#9457).
stanhu added a commit to stanhu/go-cloud that referenced this pull request Feb 29, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
2132176 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs cloud.google.com/go/storage v1.39
(googleapis/google-cloud-go#9431).
stanhu added a commit to stanhu/go-cloud that referenced this pull request Mar 1, 2024
@stanhu
blob/gcsblob: Ensure driver sets Content-Type auto-detection properly
71bf492 
google#3371 made it possible to
disable Go Cloud's Content-Type auto-detection via the
`DisableContentTypeDetection` option. However, the Google Cloud
Storage (GCS) driver still performed auto-detection even if this
option were enabled, so it was previously not possible to keep
`Content-Type` blank. This commit adds the
`DisableContentTypeDetection` option to the the driver and passes
along the value to make it possible to keep Content-Type blank in the
GCS object metadata. This enables the use of the
`Response-Content-Type` override in a signed URL.

This commit needs cloud.google.com/go/storage v1.39
(googleapis/google-cloud-go#9431).
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
@vangent @ybourgery
blob/all: Allow disabling of ContentType auto-detection during writes (…
9319caf 
…google#3371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blob/gcsblob: Allow blank Content-Type to be set
2 participants
@vangent @stanhu