Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draw area task] Location card obscures location lock button #2442

Closed
gino-m opened this issue Apr 12, 2024 · 8 comments · Fixed by #2629
Closed

[Draw area task] Location card obscures location lock button #2442

gino-m opened this issue Apr 12, 2024 · 8 comments · Fixed by #2629
Assignees
Labels
type: bug Something isn't working

Comments

@gino-m
Copy link
Collaborator

gino-m commented Apr 12, 2024

Screenshot 2024-04-12 at 8 24 28 AM

Screenshot 2024-04-12 at 8 25 41 AM

@rawbzz Is looking at this UI element now, may want to wait for final designs before fixing.

@gino-m gino-m added the type: bug Something isn't working label Apr 12, 2024
@gino-m gino-m added this to the 4. OSS launch (21-Jul-24) milestone Apr 12, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Apr 17, 2024

To consider in context of new popup card design

@rawbzz
Copy link

rawbzz commented Apr 19, 2024

Screenshot 2024-04-19 at 1 30 26 PM

@gino-m
Copy link
Collaborator Author

gino-m commented Apr 19, 2024

I like it! @rawbzz Should we make the styling of the line more consistent with the blue dot styling (e.g., white?)

Also, Can you update the text of current location to show Lat Lng without Altitude, and with Accuracy being shown when location lock is enabled?

@rawbzz
Copy link

rawbzz commented Apr 19, 2024

yes! how is accuracy measured? Also would i need to show lat lng if accuracy is shown? or just one or the other shows?

@gino-m
Copy link
Collaborator Author

gino-m commented Apr 19, 2024

For now we can just show meters (m). In the future we will probably want to add a setting for other units.

Lat/lng would always be shown, since it applies both to manual selection and auto/current location. Accuracy only applies when location lock is enabled.

@rawbzz
Copy link

rawbzz commented Apr 19, 2024

Maybe something like this??

Screenshot 2024-04-19 at 3 59 28 PM Screenshot 2024-04-19 at 3 59 34 PM

@gino-m
Copy link
Collaborator Author

gino-m commented Apr 19, 2024

@rawbzz Looks great! One nit: Can the card w/accuracy be made to fit in two lines, perhaps by showing Accuracy right aligned?

@gino-m gino-m added the ux needed Product input from PM/UX needed label Jul 30, 2024
@rawbzz
Copy link

rawbzz commented Aug 5, 2024

ah yes! I realize the updated mock wasn't here, i have this one.
Drop a pin - Collapsed

@gino-m gino-m removed the ux needed Product input from PM/UX needed label Aug 5, 2024
@gino-m gino-m modified the milestones: GA release, Beta release Aug 6, 2024
@gino-m gino-m moved this to Todo in Ground Aug 9, 2024
@shobhitagarwal1612 shobhitagarwal1612 moved this from Todo to In Progress in Ground Aug 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ground Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants