Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overlapping of info card and location FAB #2629

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Aug 10, 2024

Fixes #2442

Inline the location fab and other elements in task fragment instead of embedded layout to allow constraints to be set correctly.

Small screen Large Screen
update-info-card update-info-card-large

@gino-m PTAL?

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 57.12%. Comparing base (0e8fcde) to head (005aa5a).

Files Patch % Lines
...round/ui/common/AbstractMapFragmentWithControls.kt 42.10% 6 Missing and 5 partials ⚠️
...n/tasks/location/CaptureLocationTaskMapFragment.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2629      +/-   ##
============================================
- Coverage     57.13%   57.12%   -0.02%     
  Complexity     1356     1356              
============================================
  Files           318      318              
  Lines          7167     7179      +12     
  Branches        890      894       +4     
============================================
+ Hits           4095     4101       +6     
- Misses         2561     2564       +3     
- Partials        511      514       +3     
Flag Coverage Δ
service 57.12% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n/tasks/location/CaptureLocationTaskMapFragment.kt 66.66% <0.00%> (ø)
...round/ui/common/AbstractMapFragmentWithControls.kt 51.16% <42.10%> (-0.46%) ⬇️

Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@gino-m gino-m merged commit 265d9e5 into master Aug 11, 2024
4 checks passed
@gino-m gino-m deleted the shobhit/2442/info-card branch August 11, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Draw area task] Location card obscures location lock button
2 participants