Disable download button on pan/zoom and while estimating size #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add some sort of loading spinner or indicator? I feel like it would not be clear to me as a user why I can't press download initially after panning or zooming the map. |
JSunde
approved these changes
Sep 11, 2023
| @@ -23,6 +23,7 @@ | |||
| <color name="textOverMap">#FCFDF7</color> | |||
| <color name="blackMapOverlay">#000000</color> | |||
| <color name="lightBackground">#EDEEE9</color> | |||
| <color name="material_dynamic_neutral50">#747679</color> | |||
There was a problem hiding this comment.
Do we have a dark mode variant for this color? If so you should add it to the night colors file
There was a problem hiding this comment.
@vittorino What background color should we be using for disabled chip buttons in light and dark mode? What's the named value (e.g., primary, secondary etc) within the Material theme that we should use for the theme color?
There was a problem hiding this comment.
We spoke. We should be using "on-surface" color with a 0.12 opacity for the fill. Thanks!
…o gino-m/1855/1 # Conflicts: # ground/src/main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt # ground/src/main/res/values/colors.xml
gino-m
commented
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JSunde PTAL? @shobhitagarwal1612 FYI
Fixes #1855
Screen_recording_20230910_191022.webm
@vittorino for UX